Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile updates #739

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Makefile updates #739

merged 2 commits into from
Apr 21, 2021

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Apr 21, 2021

Did you run make format && make check?
yes

Changes:

  • updated github.com/incu6us/goimports-reviser to github.com/incu6us/goimports-reviser/v2 in Makefile : install-linters

How to test this PR:

  1. make install-linters
  2. make format && make check

jdknives
jdknives approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@jdknives jdknives merged commit 6a395d4 into skycoin:develop Apr 21, 2021
@ersonp ersonp deleted the makefile-updates branch April 11, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ersonp @jdknives